Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #8179 from video.js repo - Updated getting-started.mdx #193

Closed
wants to merge 13 commits into from
Closed

issue #8179 from video.js repo - Updated getting-started.mdx #193

wants to merge 13 commits into from

Conversation

ravixalgorithm
Copy link

issue #8176 resolved from video.js

Updated getting-started.mdx

@ravixalgorithm
Copy link
Author

@mister-ben I did the changes

@ravixalgorithm
Copy link
Author

@mister-ben can you pls review this PR and merge it??

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some suggestions inline.

src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
src/mdx-pages/getting-started.mdx Outdated Show resolved Hide resolved
Copy link
Author

@ravixalgorithm ravixalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did all the changes as instructed by @mister-ben

@mister-ben
Copy link
Contributor

We need to make some CSS changes as the bullet list doesn't look quite right. It's not the fault of these changes, it will just take a little longer to get in.

@ravixalgorithm ravixalgorithm closed this by deleting the head repository Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants